chore: call `addError` by default on error in `Emitter`'s `forEach` - Githubissues

felangel / bloc

A predictable state management library that helps implement the BLoC design pattern

https://bloclibrary.dev

MIT License

11.56k stars 3.37k forks source link

chore: call `addError` by default on error in `Emitter`'s `forEach` #4146

Closed Gambley1 closed 3 months ago

Gambley1 commented 3 months ago

Status

READY

Breaking Changes

NO

Description

Add a default addError call to BlocObserver with error and stackTrace from onError function that comes from Emitter's forEach function.

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

felangel commented 3 months ago

Closing this PR for now. If you feel strongly about this change, please file an issue describing the problem/use-case you have so that we can align before opening a pull request, thanks!