docs: add trailing slash to introduction section links

felangel / bloc

A predictable state management library that helps implement the BLoC design pattern

https://bloclibrary.dev

MIT License

11.53k stars 3.37k forks source link

docs: add trailing slash to introduction section links #4153

Closed orischwartz closed 2 months ago

orischwartz commented 2 months ago

Status

READY/IN DEVELOPMENT/HOLD

Breaking Changes

Description

All the links in the left menu on https://bloclibrary.dev are broken -- require a trailing slash.

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

felangel commented 2 months ago

@orischwartz the links seem to be working fine for me. We also have a link-check as part of the CI which is passing. Can you please elaborate on what you mean by "broken"?

orischwartz commented 2 months ago

Might have been cached on your browser, it's an HTTP 301 which is cacheable

$ curl https://bloclibrary.dev/flutter-bloc-concepts
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   162  100   162    0     0   1794      0 --:--:-- --:--:-- --:--:--  1820<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx</center>
</body>

It's fixed now, thanks