Closed furaiev closed 1 month ago
@furaiev can you share a minimal reproduction sample? I tried to reproduce but was not able using the example
app by wrapping the first page in the onboarding flow with a PopScope
and using the system back button on Android.
@felangel you are correct. I can not reproduce this in example, it looks like something with my configuration. Will check, thank you!
Status
READY
Breaking Changes
NO
Description
This PR fixes 1st page in the Flow
SystemNavigator.pop
for Android. During migration fromWillPopScope
toPopScope
(v.0.1.0) there was missed a bug that reproduces on AndroidsSystemNavigator.pop
:PopScope(canPop: true)
SystemNavigator.pop
Proposed fix:
_navigator?.pop();
to callonPopInvoked
Navigator.of(context).maybePop()
for real navigation as in previous version of the packageThis fix doesn't look like ideal, but it works and I haven't find other way to call
onPopInvoked
.Type of Change