fix(mason_logger): throw `StateError` when prompting with no terminal attached - Githubissues

felangel / mason

Tools which allow developers to create and consume reusable templates called bricks.

https://docs.brickhub.dev

938 stars 93 forks source link

fix(mason_logger): throw `StateError` when prompting with no terminal attached #1285

Closed felangel closed 3 months ago

felangel commented 3 months ago

Status

READY

Description

fix(mason_logger): throw StateError when prompting with no terminal attached
- Currently if mason_logger is used to prompt for input from a user in an environment with no terminal attached (e.g. CI), the process will hang indefinitely. This change adjusts the behavior to throw a StateError in order to make it clear that prompting for input should only be done in contexts where a terminal is attached.

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[X] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

felangel commented 3 months ago

@bryanoltman, @erickzanardo lmk what you think.