refactor(mason_logger): remove deprecated methods in `WindowsTerminal`

felangel / mason

Tools which allow developers to create and consume reusable templates called bricks.

https://docs.brickhub.dev

938 stars 93 forks source link

refactor(mason_logger): remove deprecated methods in `WindowsTerminal` #1286

Closed felangel closed 3 months ago

felangel commented 3 months ago

Status

READY

Description

refactor(mason_logger): remove deprecated methods in WindowsTerminal

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[X] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

renefloor commented 3 months ago

@felangel This change requires win32 5.4.0, but the pubspec sets the minimum to 5.0.7. As 5.3.0 requires Dart 3.3.0 everybody that's not yet on Flutter 3.19.0 or newer will resolve the latest mason_logger with an incompatible version of win32.

I think it's best to revert this change, publish that as 0.2.14 so everybody automatically gets the latest that works, and then apply it again with the correct minimum version of win32 as 0.2.15.