Shorten encodedGitDir if necessary - Githubissues

felangel / mason

Tools which allow developers to create and consume reusable templates called bricks.

https://docs.brickhub.dev

932 stars 93 forks source link

Shorten encodedGitDir if necessary #1345

Closed jtmuller5 closed 3 weeks ago

jtmuller5 commented 3 weeks ago

Status

READY

Description

This is a fix for this issue. When the git URL is too long, the file name generated exceeds 256 characters and the mason get command fails.

This change checks the length of the output file name and shortens name_url section of the output if necessary.

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ x] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

felangel commented 3 weeks ago

This isn't specific to bricks from git (see #496 and #759) so the real fix should be to generically handle this for all brick paths. I'll try to work on this shortly 👍