style: add very_good_analysis

felangel / mocktail

A mock library for Dart inspired by mockito

https://pub.dev/packages/mocktail

MIT License

617 stars 81 forks source link

style: add very_good_analysis #161

Closed lsaudon closed 1 year ago

lsaudon commented 1 year ago

Status

READY

Breaking Changes

Description

Add very_good_analysis in mocktail and mocktail_image_network

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[x] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[x] 🗑️ Chore

felangel commented 1 year ago

This is a duplicate of #154

lsaudon commented 1 year ago

Yes, but the PR has not been updated for 23 days for the CI pass.

felangel commented 1 year ago

Yes, but the PR has not been updated for 23 days for the CI pass.

That's because the latest version of Very Good Analysis introduces breaking changes and also forces an upgrade to Dart 2.18. I'd prefer if we kept #154 since that was the original PR and split into non-breaking vs breaking changes. I should have some time this weekend to revisit this -- sorry for the inconvenience and thanks for the bump 👍

lsaudon commented 1 year ago

I reverted the part that created a breaking changes in the package.