search

feldera / feldera

Feldera Continuous Analytics Platform
https://feldera.com
Other
277 stars 30 forks source link

Replace unplugin-icons with direct usage because of _virtual_~icons bug #1762

Closed Karakatiza666 closed 2 weeks ago

Karakatiza666 commented 2 weeks ago

Is this a user-visible change (yes/no): no

This PR replaces unplugin-icons with direct usage of boxicons and import of proprietary icons in the project. unplugin-icons has a bug that sometimes breaks repeated build. It's a known unresolved issue for unplugin-icons, previously it only affected local builds, now it seems to affect our CI, too

Fix https://github.com/feldera/feldera/issues/1690

gz commented 2 weeks ago

Not sure it's related to this branch, but it seems to throw some error for me: Screenshot from 2024-05-16 12-56-37

Karakatiza666 commented 2 weeks ago

The error is unrelated to this PR, this is something not significant, I may look into it if encounter it locally