search

feldim2425 / MoreOverlays

MC Mod : Brings back some of the NEI Overlays ( Mob Spawns, Chunk Bounds, Item Search)
MIT License
22 stars 18 forks source link

Update to MC 1.12.1 #37

Closed christilden closed 7 years ago

christilden commented 7 years ago

I am relatively new to creating or updating forge mods, but I believe I made the minimum edits to get More Overlays working in Minecraft 1.12.1. I played with a locally compiled version with this patch for about 30 minutes on 1.12.1 today and did not experience any crashing or other issues.

Please note: I opened this pull request against your "master-1.12" branch, but it is against my "master-1.12.1" branch. I am not certain how to perform a pull request that creates a new branch in your repository, but that was my preference based on your apparent branching strategy.

Regards, Chris Tilden

christilden commented 7 years ago

I was informed on another mod that this type of change may force 1.12.1, although I am not sure. I did not realize that and it was not my intention. I actually was just trying to get 1.12.1 support through Curseforge/Twitch!

Although, I did have to remove some methods that referenced an interface that was modified in Forge 14.22 (they removed deprecated code).

feldim2425 commented 7 years ago

I don't think this has to be done. Because there are no new methods in the GuiFacotry. A old version would only crash if there is a new method that is not implemented and only when it gets called. Having extra methods with override should just prevent compiling on 1.12.1. The only thing that might be a problem are the obfuscated names. I will try. Thank you for porting. I will just merge it, I should still be able to revert it otherwise.

feldim2425 commented 7 years ago

Well this went into the wrong branch ... whatever I will fix that later. Whoops

EDIT: I reverted the commit on the "master-1.12" branch and merged it again into a new branch "master-1.12.1"