search

feldim2425 / MoreOverlays

MC Mod : Brings back some of the NEI Overlays ( Mob Spawns, Chunk Bounds, Item Search)
MIT License
22 stars 18 forks source link

Added support for light level overlay for DrZharks Custom Mob Spawner… #57

Closed xs2007 closed 5 years ago

xs2007 commented 5 years ago

Light level overlay does not work with MoCreatures and Custom Mob Spawner by DrZhark installed. I fixed this here to check for Custom Mob Spawner on the classpath and adding the respective light level handler if it is present. Tested on Forge 2808 (MC 1.12.2) with Custom Mob Spawner 3.11.4.

Reefboi16 commented 5 years ago

@xs2007 how would I go about applying this to my server to try it out? Not sure if this is the same issue as with shaders?

xs2007 commented 5 years ago

@Reefboi16 I did not upload binaries anywhere, so you'll have to compile it yourself, unless feldim2425 decides to come online again and merge this into the master branch and releases a official new version.

Clone my fork into a fresh deobf workspace of forge dev version and run "gradlew build" from the command line. there should be plenty of tutorials on how to do this on youtube or elsewhere. Make sure to throw MoCreatures and CustomMobSpawner into the "lib" folder of the deobf workspace, or gradle will fail.

I doubt, that the issue is identical to any shader issue. The one I fixed here originated from how the light overlay data is computed. The base mod hooks into the vanilla spawn mechanics, that MoCreatures/CustomMobSpawner overwrites and deactivates (so no data for the overlay without my patch). Once the data is computed, it's projected into the game world by OpenGL methods, which is where shader issues typically arise.

cheers

feldim2425 commented 5 years ago

Implemented in 2a9878b34ad6d2bd1607475c568f7f977d62091b with a more modular system, at least I hope it is more modular.