feldim2425 / MoreOverlays

MC Mod : Brings back some of the NEI Overlays ( Mob Spawns, Chunk Bounds, Item Search)
MIT License
22 stars 18 forks source link

All colored lines are grey #62

Open bryanpalmer opened 5 years ago

bryanpalmer commented 5 years ago

In my multiplayer Enigmatica 2 modpack, several computers playing are experiencing all More Overlays lines as being thin hard-to-see grey lines instead of the bright yellow, red, and green lines. This happens with light level overlay, as well as chunk borders overlay. All 3 of my home machines experience this grey overlay problem. My work machine is running the same pack, and same java version, yet it still shows colored lines as expected.

There is a thread on reddit with others reporting the same issue, but nobody seems to have a resolution yet. I can attach screenshots if that would help explain the issue better.

feldim2425 commented 5 years ago

Hmm seems like some bug in the render state. Is there some link to at least some of the reddit posts? I will look into that but I can't guarantee that I can fix it, these bugs can be caused by other mods that don't reset their render states. But it could also be on my end that I forgot to do it properly

bryanpalmer commented 5 years ago

https://www.reddit.com/r/feedthebeast/comments/bujvb9/e2e_whats_messing_up_my_light_level_overlay/ is the reddit thread. It has a single screenshot showing the light level overlay as being thin grey lines instead of default colors.

feldim2425 commented 5 years ago

Ok I checked the image an the comments. I saw that Neat also seems to be effected, that is a good indication that something in the render pipline is messed up. In theorey it could be everything from my mod, to any other mod and in some cases even drivers. It might be a bit of work until I can pinpoint the error.

bryanpalmer commented 5 years ago

Ok, if there's anything I can do to test out or help isolate the issue let me know. As I mentioned, it works fine on my work computer, but exhibits this behavior on my 2 gaming desktops and my laptop at home. And I know the screenshot doesn't show it, but this also seems to affect the colored health indicators for mobs in the world also. At home, they all have grey health bars, but at work they have green/yellow/red healthbars. I know that isn't part of your mod, but still part of the rendering issue.

feldim2425 commented 5 years ago

Is the health indicator also effected if you turn the overlays off? (chunk and light)

bryanpalmer commented 5 years ago

Yes, I noticed that being effected even with overlays turned off. It is also effected using the different BetterFPS algorithm's from vanilla to the default Riven's "Half" algorithm.

Nattywwc commented 5 years ago

I also have this issue with the All the mods 3 Remix modpack on the beta branch. The current Live version 1.3.0 doesn't have the issue, only the beta version 1.3.1 has the problem. I'm currently investigating the changes between the two versions and which updated (or added) mod causes the issue. The changelog I'm using as a guide to find the issue is here https://github.com/AllTheMods/ATM3-Remix/blob/dev/changelogs_detail/changelog_atm3-r_1.3.1_full.txt#L4

EDIT: It's been pointed out to me that just because a change in this modpack has broken the overlays doesn't mean that it's the same mod as the other modpack. I'll still try and figure out which mod is causing it and then bring it up with them.

drakray commented 5 years ago

Hi, I can maybe help a little. I found a recent bug in Roots, where the MoonRay(entities:roots:auspicious_point) is visible in plain day. When in render distance of the MoonRay, the Overlay is visible in normal color. Getting out of MoonRay render distance make the Overlay gray again.

EDIT: Also, sometime I start the game and everything is ok, Overlay And MoonRay, strangely.

xtrux commented 5 years ago

i have the bug on enigmatica 2

thakyZ commented 5 years ago

So I had this bug yesterday after updating some mods, but since then when I downgraded only of the mods which was Mekanism and it's own official add-ons it still didn't work. But then today I boot up my game to try it out, and it works all of a sudden not sure if that has anything to do with it... The version number changes of Mekanism are as follows: 9.7.8.379 -> 9.7.4.375

EDIT: I updated some other mods, which was MrTJP core and all of the Project Red add-ons other than World, which I don't like using. I will recheck my findings.

xtrux commented 5 years ago

let us know specifics if you manage to narrow it down

thakyZ commented 5 years ago

So I can't seem to figure out what exactly is causing the issue, but it seems to possibly be a load order issue, since it happens to work 1/5 times when booting the game. I have so many mods that it will take a while to figure out what exactly is causing it. But from what I can tell it's not Mekanism or MrTJP core and ProjectRed.

MindCaged commented 5 years ago

I got the same issue, I downloaded the Omnifactory 1.2.1 modpack, and it was working right, then I installed a couple mods and started getting the grey lines, it effected this mod and the scannable mod. I was able to get it back to normal when I disabled Random Psideas, but then I installed a few other mods and it started doing it again. Then I tried random stuff managed to get Random Psideas working and I had everything working, then I had to shut down the game, tried to start it the next day and the problem is back.

Okay, now I just tried disabling Foamfix and it works right now. I'll keep playing with it I guess. Okay, so for right now at least disabling Foamfix seems to fix it for me, though it could just be a coincidence as it also seemed to fix it before when I disabled Random Psideas, so others might have to test.

ShinryuAspect commented 5 years ago

I'm also having this problem. I'm playing on a custom made modpack. But there's a thing annoying me. I'm using the Hooked mod and, anytime I use the hook (either while I'm flying towards a block or sticked to a block) the light overlay seems to work as expected (no grey lines) but, as soon as I release the hook, the lines turn back to grey. Don't know if this will be of any help but I thought it was worth mentioning.

LukaTheHero commented 5 years ago

I found what's causing it. Astral sorcery sky renders seem to be the cause.

astralsorcery.cfg

S:weakSkyRenders <0
 >

should fix it

MindCaged commented 5 years ago

There seem to be a lot of things that cause this, it's pretty random. And no it's not entirely Astral Sorcery as I have this problem in Omnifactory and it doesn't even have Astral Sorcery installed. It's definitely something to do with rendering, There's definitely some sort of conflict, but it seems to apply to many different mods at random, it seems to come and go randomly as I add/remove/enable/disable mods. I even have had times where I disable a mod that seems to fix it, and then it comes back when I add some other mod, and I get it working again somehow with the original mod re-enabled. I really would love to know how to fix this glitch. Is the problem in forge? Is there some mod that all these people have in common? Heck, the other day the problem came back right after I installed tinker's construct and various addons for it.

drakray commented 5 years ago

Just a quick input: could it be caused by Java itself? I know Forge(MTG) is having sound issue with JRE >= 1.8.0_211

I am currently using JRE 1.8.0_221

MindCaged commented 5 years ago

Also, could it possibly have anything to do with the number of installed mods or something? Playing around randomly, sometimes when I remove mods, but also sometimes when I /add/ mods it seems to come and go, I actually added mods the other day and suddenly it was working properly again. I currently have an odd number of mods in my folder. Or maybe something that happens when you add/remove mods cause it to toggle between working and not? The last mod I installed was Just Enough Resources and it got it working right again, so it seems completely random. It's very confusing. I'm guessing it's got to be happening at a pretty low level, does anybody know if anybody has reported it to the forge people? It seems to be a bug that effects a wide variety of mods, seemingly anything with an overlay. I know it effects not only More Overlays, but also Scannable, and Advanced XRay. I'm not familiar enough with how mods draw the overlays, I'm wondering if they all call the same code, and maybe there's something glitched in that code that changes whatever color it's /supposed/ to be to like white/grey.

WindFox commented 5 years ago

I started getting this when I installed Phosphor and VanillaFix. I had to remove both to fix it.

Which is odd because Mystical Skies has VanillaFix and More Overlays and does not have this issue.

feldim2425 commented 5 years ago

I don't think JVM or the number of Mods is the problem. The rendering is actually done by native libraries outside the JVM (OpenGL, LWJGL). If somehow wrong data leaks into the actual GL calls it shoult have other effects too, like messed up positions. I am certain that this is a issue with the render states in opengl.

EDIT: The renderstates are modified by the mods and minecraft itself. It is for example responsible to select if a texture should be used or just a single color, if lightning should be applied, if transparency should be taken into account, if the object can be blocked by other things in front of it (depth), ... I don't know enough about OpenGL to tell for certain what setting is responsible for that. It can be that some mod sets a state and forgot to reset it, of I forgot to set a state (or both)

N0tez commented 4 years ago

For me Hooked was the reason for the grey lines. But Hooked may not be the only one going this. There is ton of mods out there what may do the same.

I hope this helps finging the problem. And also thanks for ShinryuAspect for pointing that out. I might still be looking over the mods. (Sorry about my english ;( )

Tychology commented 4 years ago

I have the same problem too. The overlays from Scannable also seem effected.

ElvenChaos commented 4 years ago

I've been putting together a private modpack and noticed this issue crop up. I also noticed that at the same time when this issue crops up that fog effects seem to be broken to, whether from vanilla blindness or thaumcraft warp effect fog or even just render distance fog. The render distance fog just doesn't render, but the other two fog effects, while they don't seem to render, do render on top of mobs, making their image fogged and nothing else. I'm not sure how the render pipeline works, but perhaps a mod (or mods) have managed to screw up render layers?

I haven't managed to narrow down any particular offending mods in my modpack yet, but I did find out that installing optifine (something I wanted to avoid since I have other optimization mods as well as tinker's construct) seems to fix both the rendered colors from this mod as well as the fog effect simultaneously. Issue is definitely larger than this mod.

Hopefully this information is helpful.

EDIT: After a while of trying to narrow down mods causing bugs, I found out that the fog issue seems unrelated to the color issue. Fog issue was caused by p455w0rd's library shader setting.

WindFox commented 4 years ago

@ElvenChaos Unfortunally for me, I added Optifine to my private pack to maybe fix this issue and I still get it.

ElvenChaos commented 4 years ago

In a similar vein I tried to remove phosphor and vanillafix and that didn't work for me, wtf is this bug :x

EDIT: I was wrong b/c I assumed fog effect was directly related. Removing VanillaFix completely fixed the grey-color bug for me.

WindFox commented 4 years ago

I think this Astral Sorcery issue is related because when this issue occurs, AS also goes grey. https://github.com/HellFirePvP/AstralSorcery/issues/978

WindFox commented 4 years ago

So, I just had something odd happen just a few moments ago.

Right now, the lines are grey in my private pack, but when I activate a Loopcast Spell from Psi, the color returns....until I shut off the spell.

WindFox commented 4 years ago

I've done some testing and managed to find ONE possible cause.

I've narrowed down one of my packs to just a few mods:

Using Astral Sorcery as a faster check since when this issue shows up, it also affects AS as well; I started removing mods from my pack (in a separate instance) until the issue went away. (and I removed a lot of mods including performance mods like VanillaFix and such).

The moment I took out Wizardry, it fixed it self. I still narrowed down the list until I get the above listing. And every time I remove Wizardry, the problem goes away. (and yes, I also took out AS, JEI, and anything else to test)

The only thing I cannot figure out is why it mostly works in the my actual pack (for the most part), but as I posted a few days ago, PSI's loopcast bullet fixed the issue while it was running. So...

Please feel free to double check my work. And I did say 'ONE' of the possible causes, since there are a LOT of mods and who knows what interactions can cause (or fix) this issue.

Edit: Well, looks like I'm not the only one that found this out and hoo-boy this is a crazy bug. https://github.com/Electroblob77/Wizardry/issues/208

lectavison commented 4 years ago

I had this issue with a pack, when I upped the ram I had allocated to Minecraft from 8gb to 12gb. when I decided to drop it back down to 8gb the colors came back. I suspect with the more ram allocated there is something that is left loaded and when you have less ram allocated it will unload itself, to free up space.

xtrux commented 4 years ago

malasis doors also cause this fyi. more specifically the hitech door. il test the others

invalidtask commented 4 years ago

This happens when you enter into claimed chunks. It reverts to working properly when you leave the claimed chunks. I've consistently been able to repeat this.

Modpack I'm using is ATM3: Remix v1.6.0

magmagdigdig commented 3 years ago

I stopped installing YUNG's Better Caves (Forge1.12.2) and the gray bug stopped.