felias-fogg / SoftI2CMaster

Software I2C Arduino library
GNU General Public License v3.0
368 stars 100 forks source link

Rename sketch file to match folder name #36

Closed per1234 closed 2 years ago

per1234 commented 6 years ago

The Arduino IDE requires the sketch folder name to match the filename of the primary sketch file. On a filename case-sensitive OS like Linux, this includes matching case. This change causes the example sketch to be accessible via the Arduino IDE's File > Examples > LIBRARYNAME menu after the library is installed.

bxparks commented 3 years ago

@felias-fogg: I hit this bug yesterday. Can you merge this? It's a single character fix, it's 3 years old, it deserves a chance.

felias-fogg commented 2 years ago

I did that already. Thanks for pointing it out.

per1234 commented 2 years ago

I did that already.

@felias-fogg not that I can see: https://github.com/felias-fogg/SoftI2CMaster/blob/master/examples/I2CShell/I2Cshell.ino

Note that the folder name is "I2CShell", but the sketch file name is "I2Cshell.ino". The first has a capital "S", the second has a lower case "s".

Windows and macOS with the default settings can be tricky like that because they consider "I2Cshell.ino" and "I2CShell.ino" to be the same file names. But Linux does not.