Closed felipeffm closed 2 days ago
Attention: Patch coverage is 76.19048%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 93.91%. Comparing base (
e1683e3
) to head (10878dc
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Related issue #102
@felipeffm as we've talked today, I think it would be nice to have a structure similar to sktime, with one function for each dataset I liked the idea of having a file with common plotting functions used in the documentation examples as you are implementing. Thank you very much for proposing this PR :)
might this also be relevant? https://github.com/sktime/sktime/pull/4333
might this also be relevant? sktime/sktime#4333
yes! Felipe told me he won't be able to finish this PR due to bandwidth limitation, I'm planning to implement it inheriting BaseObject
from skbase - now potentially BaseDataset
from sktime
. I can imagine that this sktime's PR still need some work, and all datasets would need to be adapted, isn't it?
I can imagine that this sktime's PR still need some work, and all datasets would need to be adapted, isn't it?
Yes, that's right - it is just a design study at the moment, not even a fully developed API. It was created for the benefit of some contributors who were considering to work on this but then abandoned the project.
So, if you create an API in prophetverse
and it looks good and adaptable, I would very much also like to adapt it for sktime
. Or, if you even implement such an interface in sktime
first, and then "inherit" it in prophetverse
, that would be even nicer! Either would be appreciated, as I also do not have bandwidth for the data sets module at the moment.
Alright, I'll implement it in sktime and then use it in Prophetverse. I'm currently on vacation and should start working on that in about 2 weeks.
Closed in favour of #130
Discuss:
how make documentation more readable for all: Sugestion: separe advanced concepts and make it visual
how to simplify the code at examples. Sugestion: preprocess outside code