search

felipebz / zpa

Parser and static code analysis tool for PL/SQL and Oracle SQL.
https://zpa.felipebz.com
GNU Lesser General Public License v3.0
211 stars 77 forks source link

Add support for pragma deprecate #143

Closed l0wlik34G6 closed 3 years ago

l0wlik34G6 commented 3 years ago

With this PR I want to add the support for pragma deprecate. I found out, that this is not supported while trying to create unit tests for a custom rule.

I didn't understand a lot of your code, however I added it based on what was there. I also added the unit test for it. However the way of doing the unit test was really strange, not sure if I did it right.

Unfortunately, I could not make any further tests than that:

  1. I'm so not a maven guy and
  2. I was not able to run the commands from the readme. I always received errors. (which couldn't have been related to my implementation)

Maybe it makes the way into the source :)

l0wlik34G6 commented 3 years ago

I understand now the unit test and what I did wrong, an update/a commit will follow...

l0wlik34G6 commented 3 years ago

pragma declaration tests now still ran successfully :)

felipebz commented 3 years ago

Great work, @l0wlik34G6. Thanks for your contribution 👍