felipec / git-reintegrate

Tool that allows the regeneration of integration branches
22 stars 8 forks source link

Problem if GIT_EDITOR contains an argument #1

Closed fingolfin closed 10 years ago

fingolfin commented 10 years ago

I have been playing with "git reintegrate", and really like, it, but I run into one snag: My EDITOR variable contains a command with arguments, i.e. not just "foo" but rather "foo --param". This has worked fine for me so far (and works e.g. with git commit and rebase -i), but git reintegrate chokes on it.

I can work around this by putting the whole editor command into a shell script and then let EDITOR point at that script. But it would of course be nicer if "git reintegrate" would just grok it as it is. Or, barring that, at least print a more helpful error message than fatal: ;-)

felipec commented 10 years ago

Fixed.