felipecsl / AsymmetricGridView

Android ListView that mimics a GridView with asymmetric items. Supports items with row span and column span
http://felipecsl.com/AsymmetricGridView
MIT License
1.84k stars 431 forks source link

Readme ambiguity - RowSpan = 2 and ColumnSpan = 2 #44

Closed bemusementpark closed 9 years ago

bemusementpark commented 9 years ago

This seems to imply any size up to RowSpan=2, and ColSpan=2 is acceptable, because obviously RowSpan=1, ColSpan=1 is acceptable, so it implies that ColSpan=1,RowSpan=2 and vice-versa are also acceptable.

You should make that clearer... or implement that!

felipecsl commented 9 years ago

that is acceptable. can you clarify please?

felipecsl commented 9 years ago

you can use any combination of rowspan/colspan you want

bemusementpark commented 9 years ago

When I used rowspan=2 and colspan=1 gives me Views that hang off of the right edge of the screen.

bemusementpark commented 9 years ago

Perhaps the documentation could more explicitly state that 1x2 and 2x1 are not well supported as of yet.

and that 1x1 AND 2x2 are.