Closed GoogleCodeExporter closed 8 years ago
I don't think SDK _throws_ this exception. It simply prints it.
So this looks more like a cosmetic issue to me. Please confirm it's cosmetic in
your case too.
I guess we can try to stop SDK from printing it.
Original comment by peter.ry...@gmail.com
on 15 Mar 2012 at 9:45
You are right, exception is not thrown but logged as SEVERE:
>AbstractWsConnection.java:114 LOGGER.log(Level.SEVERE, "Connection read
failure", e);
My application has a global handler which displays exceptions logged with this
severity to users so that users can report them back to us and we can fix them.
The problem here is that I have no way of "catching" this logger event. I could
perhaps create a filter and ignore all logger events from Hybi00WsConnection
class but I'm not very keen on that - what if there is a real exception which
is important to user?
I'm not sure what's the best resolution. Ideally the SDK would correctly
interpret this state as "browser was closed" and fire appropriate SDK event and
not log this exception as it is not a problem. Alternatively your thread could
remember the problem and throw an exception (instead of logging it) next time
when an SDK API call is made which depends on thread being in a healthy state.
What do you think? I will look into filtering it out for now on my side. Thanks!
Original comment by dvdk...@gmail.com
on 20 Mar 2012 at 1:06
Original comment by peter.ry...@gmail.com
on 20 Mar 2012 at 2:56
Patch is proposed:
https://chromiumcodereview.appspot.com/9959080/
INFO message is still planned to be logged, as currently Chrome incorrectly
skips "close" protocol frame and simply silently closes.
Original comment by peter.ry...@gmail.com
on 2 Apr 2012 at 9:12
Fixed in HEAD
Original comment by peter.ry...@gmail.com
on 16 Apr 2012 at 4:55
Fixed in 0.3.6
Original comment by peter.ry...@gmail.com
on 2 Jul 2012 at 6:22
Original issue reported on code.google.com by
dvdk...@gmail.com
on 15 Mar 2012 at 9:28Attachments: