search

felipefdl / wercker-status

Add Wercker status of the project to the Atom status bar.
https://atom.io/packages/wercker-status
MIT License
10 stars 4 forks source link

URL Matching Issue Fix #1

Closed Omegaice closed 10 years ago

Omegaice commented 10 years ago

I noticed that when I installed this package it would show Wercker:... and then disappear. I edited the code and found that wercker's api returned a ssh repository and my local repository was cloned via https. This meant that the repositories didn't match and thus the status was never displayed.

I updated the code to parse out the username and repository from whatever the local repository was cloned as and then test both against wercker's api response to see if it matches.

felipefdl commented 10 years ago

@Omegaice Thanks, this created another problem, private repositories ("without github") stopped working, we have to think of another solution.

Exemple: git@bitbucket.org:koshoo/shashtag-web.git or https://felipefdl@bitbucket.org/koshoo/shashtag-web.git

Do you want to do this, or can I do?

Omegaice commented 10 years ago

Hmm, I don't have any private bitbucket accounts setup with Wercker so it might be easier for you.

It seems that bitbucket also has a similar structure for ssh and http cloning which makes things easier but I am not sure how to handle cases such as people hosting their own repository and checking it out differently etc.

felipefdl commented 10 years ago

I believe that following the same pattern from github and bitbucket, will cover the majority of cases.

felipefdl commented 10 years ago

I'm correcting now, thank you for your cooperation!

=D