search

felipefdl / wercker-status

Add Wercker status of the project to the Atom status bar.
https://atom.io/packages/wercker-status
MIT License
10 stars 4 forks source link

Possible to hide password #5

Closed SamVerschueren closed 9 years ago

SamVerschueren commented 9 years ago

Is it possible to hide the password and username if the token is created? It doesn't feel right to have it in plain text in the editor.

felipefdl commented 9 years ago

@SamVerschueren Sure, I agree. But I need store the password because the werker token is temporary. I gonna analyse this.

SamVerschueren commented 9 years ago

Ah oke, didn't knew it was temporary. If I find the time I will also have a look into this.

IyadAssaf commented 9 years ago

Just to chime in on this, I too am not terribly comfortable having my password in plaintext in the settings but I would be happy enough with the password field just having hidden characters.

Looking through the atom docs and forums, it looks like these guys have a good solution to get this working since atom doesn't allow you to set the input type for passwords - https://discuss.atom.io/t/password-fields-when-using-editorview-subview/11061/5

I'm happy to make a pull req at some point if you'd like.

felipefdl commented 9 years ago

Nice @IyadAssaf ! I will be happy accept your pull request.