search

felipegiacomozzi / the-trove-downloader

Downloads files from The Trove Rpg website
49 stars 3 forks source link

V1.0.10can not skip a folder. the process always stops because of a naming error there. #16

Open gillopillo opened 3 years ago

gillopillo commented 3 years ago

The folder 'Basic Roleplaying (BRP) (d100)' gives errors.

It tries multiple times to download the books in the core books/ folder, then fails.

I suspect it's because The script checks the folder core%20Books%20/ instead of what is actually created on my drive: core%20books/

The error most likely comes from the folder structure in the website, as the folder that the script is looking for would end with a space character (not possible in windows).

I try to instruct the program to skip Basic roleplaying (BRP) (d100) but it does not happen. I tried to download the files manually, but It still does not see them as completed and keeps going back to the error, as It can never find them in the directory named with a space in the end.

Am I doing something wrong when putting the folder to skip? i tried both the local path and the url with no effect.

the-trove-downloader.log

turnerjoy commented 3 years ago

Confirm also having this problem on Windows

https://thetrove.is/Books/Basic%20Roleplaying%20%28BRP%29%20%28d100%29/Core%20Books%20/

Not solved in 11

felipegiacomozzi commented 3 years ago

There was still a problem with the whitespace in the folders. Just release a new version that hopefully fixes that.

Could you guys try it out? https://github.com/felipegiacomozzi/the-trove-downloader/releases/tag/1.0.12

Meketh74 commented 3 years ago

@gillopillo The syntax for the folders that shoudl be skipped needs to be finished with a comma (,). This also applies if you want to skip only 1 folder. So the correct syntax is: 'folder to be skipped/,' e.g. you want to skip the folder LANG then you would enter LANG/, Hope that helps.

@felipegiacomozzi: Maybe also a minor point for improvement in a future version for usability reasons

Best M.

beowulf88 commented 3 years ago

@Meketh74 since it seems you have managed to get it to work can you post an example of the full syntax? Do you need to enter https://thetrove.is/Books/Dungeons%20&%20Dragons%20[multi]/Premium%20Editions/, to skip that folder or C:/the_trove/Books/Dungeons & Dragons[multi]/Premium Editions/, ? Or do you need to have the folder names that include spaces in " "?

EDIT: Forget it, I figured it out