felipegiacomozzi / the-trove-downloader

Downloads files from The Trove Rpg website
50 stars 3 forks source link

Error: Object reference not set to an instance of an object. #20

Open beowulf88 opened 3 years ago

beowulf88 commented 3 years ago

Hi there. I don't know how actively you are maintaining this project but I got the error in the subject 2-3 times in a row when trying to download the trove. Every time it occured on a different file. The second time it actually occured on a file that the first time around it had downloaded just fine, so I assume the issue is not in a particular file name or something screwing with the script. the-trove-downloader.log

Meketh74 commented 3 years ago

Hi @felipegiacomozzi,

same error for me several times in a row but with the same file/folder.

the-trove-downloader.log

Maybe because of weird naming in the folder for some files e.g. Encyclopaedia Arcane - Abjuration - Shielded by Sorcery {MGP1021}.pdf

It would be great if you could look into this. Thanks a lot for the great tool and the work you put into it.

Best M.

Torianor commented 3 years ago

Hi, got the same error with another file, hope you can use the log^^

the-trove-downloader.log

felipegiacomozzi commented 3 years ago

Hi @beowulf88 , @Meketh74 and @Torianor . Just released a new version that hopefully fixes this error.

https://github.com/felipegiacomozzi/the-trove-downloader/releases

Could you guys try it out?

beowulf88 commented 3 years ago

Seems to be working great now. Thanks for updating it!

Torianor commented 3 years ago

Yes, the only problem the trove has now is a endless loop

[22:17:46] Checking Item see also Books - Tri-Stat System/ [22:17:46] Loading Page https://thetrove.is/Books/A%20Game%20of%20Thrones%20%28tri-stat%29//see%20also%20Books%20-%20Tri-Stat%20System/ [22:17:47] Found a redirect url https://thetrove.is/Books/A%20Game%20of%20Thrones%20%28tri-stat%29//see%20also%20Books%20-%20Tri-Stat%20System/ [22:17:47] Redirecting to https://thetrove.is/Books/Tri-Stat%20System/ [22:17:47] Loading Page https://thetrove.is/Books/Tri-Stat%20System/ [22:17:47] Checking Item Parent directory/ [22:17:47] Checking Item A Game of Thrones (See Books - A Game of Thrones)/ [22:17:47] Loading Page https://thetrove.is/Books/Tri-Stat%20System//A%20Game%20of%20Thrones%20%28See%20Books%20-%20A%20Game%20of%20Thrones%29/ [22:17:47] Found a redirect url https://thetrove.is/Books/Tri-Stat%20System//A%20Game%20of%20Thrones%20%28See%20Books%20-%20A%20Game%20of%20Thrones%29/ [22:17:47] Redirecting to https://thetrove.is/Books/A%20Game%20of%20Thrones%20%28tri-stat%29/ [22:17:47] Loading Page https://thetrove.is/Books/A%20Game%20of%20Thrones%20%28tri-stat%29/ [22:17:47] Checking Item Parent directory/ [22:17:47] Checking Item see also Books - Tri-Stat System/ [22:17:47] Loading Page https://thetrove.is/Books/A%20Game%20of%20Thrones%20%28tri-stat%29//see%20also%20Books%20-%20Tri-Stat%20System/ [22:17:47] Found a redirect url https://thetrove.is/Books/A%20Game%20of%20Thrones%20%28tri-stat%29//see%20also%20Books%20-%20Tri-Stat%20System/ [22:17:47] Redirecting to https://thetrove.is/Books/Tri-Stat%20System/ [22:17:47] Loading Page https://thetrove.is/Books/Tri-Stat%20System/ [22:17:48] Checking Item Parent directory/ [22:17:48] Checking Item A Game of Thrones (See Books - A Game of Thrones)/ [22:17:48] Loading Page https://thetrove.is/Books/Tri-Stat%20System//A%20Game%20of%20Thrones%20%28See%20Books%20-%20A%20Game%20of%20Thrones%29/ [22:17:48] Found a redirect url https://thetrove.is/Books/Tri-Stat%20System//A%20Game%20of%20Thrones%20%28See%20Books%20-%20A%20Game%20of%20Thrones%29/ [22:17:48] Redirecting to https://thetrove.is/Books/A%20Game%20of%20Thrones%20%28tri-stat%29/ [22:17:48] Loading Page https://thetrove.is/Books/A%20Game%20of%20Thrones%20%28tri-stat%29/

But the downloader function without a hitch, thx for that!^^

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ Am Montag, 14. Dezember 2020 22:10 schrieb beowulf88 notifications@github.com:

Seems to be working great now. Thanks for updating it!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

felipegiacomozzi commented 3 years ago

@Torianor it seems you are using an older version. In the last release I removed the redirect navigation, so it shouldn`t go on a loop anymore.