felipehuerta17 / CryoEvap

A Python software for the simulation of the evaporation of cryogenic liquids in storage tanks
GNU General Public License v3.0
3 stars 0 forks source link

Review evaporation rate #1

Open felipehuerta17 opened 7 months ago

felipehuerta17 commented 7 months ago
felipehuerta17 commented 7 months ago

The problem was with the change of signature of

set_HeatTransProps(self, U_L, U_V, T_air, Q_b_fixed=None, Q_roof=0, eta_w = 0):

In an initial version, Q_roof was defined before Q_b_fixed. Changing the LNG evaporation notebook for setting Q_b to large_tank.set_HeatTransProps(U_L, U_V, T_air, Q_b_fixed = Q_b, Q_roof = 0, eta_w = 0.90) resolved the issue and produced BOG rates aligned with Huerta and Vesovic (2019)

image