search

felipenoris / hyper-reverse-proxy

A simple reverse proxy for use with Hyper and Tokio
Apache License 2.0
181 stars 63 forks source link

feat: use criterion for benching #32

Closed somehowchris closed 2 years ago

somehowchris commented 2 years ago

The rust integrated benching feature (which is also unstable) uses a naive approch.

I have come to learn criterion better. It is not a perfect solution and ci result aren't all the time trustworthy but are a good indication.

This also adds a bench feature which allows the benching parts to access internal functions

somehowchris commented 2 years ago

https://github.com/boa-dev/criterion-compare-action/issues/51

somehowchris commented 2 years ago

@felipenoris I'm having final exams, so if one answers or fixes https://github.com/boa-dev/criterion-compare-action/issues/51 I will be able to change or check something in 3-4 weeks sry for that 🦄

Would be lovely to see all the changes in action :)

felipenoris commented 2 years ago

@somehowchris no worries! Good luck!

somehowchris commented 2 years ago

I removed the PR gh action for criterion as they do not seem to care about their gh action and using gh actions for benching is kinda risky as its infra is on a public could which means your results will be load depending and for something like valgrind we do not know how the l1,l2 & l3 cache behaves for ghs infra

somehowchris commented 2 years ago

This should solve #37 and #31