search

felipeochoa / rjsx-mode

A JSX major mode for Emacs
https://github.com/felipeochoa/rjsx-mode
MIT License
639 stars 32 forks source link

Warning (js2-mode): For JSX support, use js-mode with js2-minor-mode #103

Closed bzalasky closed 5 years ago

bzalasky commented 5 years ago

When I enable rjsx-mode (after pulling the latest Spacemacs changes in the develop branch), a warning buffer is opened up with the following message Warning (js2-mode): For JSX support, use js-mode with js2-minor-mode. This is coming from js2-mode, but seems to be an issue that'd be limited to users of rjsx-mode and/or Spacemacs. I'm not sure what the best approach to fixing this might be, but it's incredibly disruptive... not sure why this would ever be a useful warning to throw.

Apologies if this is the wrong place for this issue, but wasn't sure where to start.

bzalasky commented 5 years ago

I think I found the issue. It's in js2-mode, but happens to be impacting rjsx-mode as well https://github.com/mooz/js2-mode/commit/999c0e7d96f4d5be0950b6506d732dc3d7c53635

bzalasky commented 5 years ago

I've opened the issue here https://github.com/mooz/js2-mode/issues/532. The discussion there may be relevant for rjsx-mode.

bzalasky commented 5 years ago

Based on the discussion in mooz/js2-mode#532, I've opened https://github.com/felipeochoa/rjsx-mode/issues/104 here.