Inherit from js2-mode instead of js2-jsx-mode

felipeochoa / rjsx-mode

A JSX major mode for Emacs

https://github.com/felipeochoa/rjsx-mode

MIT License

641 stars 32 forks source link

Inherit from js2-mode instead of js2-jsx-mode #105

Closed bzalasky closed 5 years ago

bzalasky commented 5 years ago

See the following issues for context:

https://github.com/felipeochoa/rjsx-mode/issues/103
https://github.com/mooz/js2-mode/issues/532
https://github.com/felipeochoa/rjsx-mode/issues/104

tzz commented 4 years ago

@felipeochoa without this PR, 0.4.0 (the stable MELPA release) generates an annoying warning about the js2-mode inheritance. Would you consider making a new stable release? Thank you.