Don't inherit default font-lock faces.

felipeochoa / rjsx-mode

A JSX major mode for Emacs

https://github.com/felipeochoa/rjsx-mode

MIT License

641 stars 32 forks source link

Don't inherit default font-lock faces. #127

Closed jcs090218 closed 4 years ago

jcs090218 commented 4 years ago

I find out these inherit faces.

rjsx-tag -> font-lock-function-name-face
rjsx-attr -> font-lock-variable-name-face
rjsx-text -> font-lock-string-face

Maybe not to inherit and just specify a color for it?

felipeochoa commented 4 years ago

I agree the first 2 inheritances are a bit iffy, but we do need to inherit from something. Otherwise whatever color we select is going to look awful in different themes. I picked the font-lock faces because they are likely to be properly set in themes.

If there are better faces to inherit from, I'll happily merge a PR!