Feature: Jump to beginning and end of tag

felipeochoa / rjsx-mode

A JSX major mode for Emacs

https://github.com/felipeochoa/rjsx-mode

MIT License

639 stars 32 forks source link

Feature: Jump to beginning and end of tag #91

Closed larebsyed closed 5 years ago

larebsyed commented 5 years ago

Description

In rjsx mode there is no way to jump to closing tag or beginning tag
This PR adds three more interactive functions rjsx-jump-to-closing-tag, rjsx-jump-to-opening-tag and rjsx-jump-tag
With rjsx-jump-tag we can alternate between beginning and end tag
rjsx-jump-tag is bound to C-c C-j by default

Reference Issue: #90

larebsyed commented 5 years ago

@felipeochoa Please review. Thanks

larebsyed commented 5 years ago

@felipeochoa any update?

larebsyed commented 5 years ago

@felipeochoa Fixed the review issues, Please let me know if further changes are requested.

felipeochoa commented 5 years ago

Added a couple small comments. Otherwise we just need a few tests for this and it looks good. Thanks!!

larebsyed commented 5 years ago

@felipeochoa Fixed and replied to your comments

felipeochoa commented 5 years ago

Final thing before merging: Can you add a couple of tests? You can look in rjsx-tests.el at either rjsx-rename-tag-at-point or rjsx--tag-at-point for inspiration

larebsyed commented 5 years ago

@felipeochoa Added a couple of test, please merge if you find them enough

felipeochoa commented 5 years ago

Both look great! Just missing one test for the rjsx-jump-tag function and we'll be ready to go!

larebsyed commented 5 years ago

@felipeochoa Added another test for rjsx-jump-tag, I was not sure how should I test it as it uses the same funcation rjsx-jump-opening-tag and rjsx-jump-closing-tag at the back. Let me know if it is fine like this.

larebsyed commented 5 years ago

@felipeochoa should I merge this?

felipeochoa commented 5 years ago

Thank you!!

littlehome-eugene commented 5 years ago

great, it's C-c C-j not C-c C-g by default..

larebsyed commented 5 years ago

Edited it Thanks

wminshew commented 3 years ago

something odd I noticed: jumping from the close tag to open tag only works if they're on different lines. Not saying it's a bug, but something that felt worth noting (jumping from open tag to close tag on same line works as expected)