Indentation is unexpected without parenthesis

[axelson]

I expect different indentation for the following code:

Actual:

  render () {
    var a = (
      <div>
        abc
      </div>
    )
    var b = <div>
              abc
            </div>
  }

Expected:

  render () {
    var a = (
      <div>
        abc
      </div>
    )
    var b = <div>
      abc
    </div>
  }

Basically I expect similar indentation with and without the parentheses. Is this something that is accomplishable in rjsx-mode?

Please check if the bug still exists when using js2-jsx-mode (if applicable). If so, it is most likely an upstream bug and should be reported there.

js2-jsx-mode seems to have broken indentation in this scenario as well but in a different way

[felipeochoa]

Nope, that's not possible currently, but PRs welcome

[axelson]

Do you have any pointers on implementing this type of indentation?

[felipeochoa]

You may be able to get it done simply by editing `rjsx--indent-line-to-offset'

The indentation code works by tracking a parent JSX element, relative to which we indent children. This all happens here.

[vaer-k]

This becomes pretty unpleasant when formatting stateless components with arrow functions:

const Stuff = ({ value, children }) =>
  <form>
    {children} 
    <input
      type="text"
      value={value}/>
  </form>

becomes

const Stuff = ({ value, children }) =>
      <form>
      {children} 
      <input
type="text"
value={value}/>
  </form>

[knobo]

But "this" what @vaer-k is refering to is a bug in js2 (I think) /mooz/js2-mode/issues/526