Closed GoogleCodeExporter closed 9 years ago
I am seeing an error with badinc in some cases (maybe all the time?, I think it
depends what version of clang I'm synced to) with char_traits being removed
from the include-list for <string>. The other errors are new to me, though.
Some are clearly OS X specific:
-#include <errno.h> // for errno
+#include <sys/errno.h> // for errno
and size_t being in unistd.h and not stddef.h. (That last one surprises me,
actually.)
It looks like the rest of the warnings are there for me too:
---
tests/badinc.cc:717: actual diagnostic doesn't match expectation.
Expected: regular expression "I1_Class is...*badinc-i1.h"
Actual: I1_Class needs a declaration, but does not provide or directly #include
one.
tests/badinc.cc:720: expecting 1 diagnostics; actually had 0:
tests/badinc.cc:755: expecting 4 diagnostics; actually had 3:
I1_Class needs a declaration, but does not provide or directly #include one.
I1_TemplateClass is defined in "tests/badinc-i1.h", which isn't directly
#included.
std::vector is defined in <vector>, which isn't directly #included.
tests/badinc.cc:824: expecting 3 diagnostics; actually had 2:
I1_Class needs a declaration, but does not provide or directly #include one.
I1_TypedefOnly_Class is defined in "tests/badinc-i1.h", which isn't directly
#included.
tests/badinc.cc:829: expecting 4 diagnostics; actually had 3:
I1_Class needs a declaration, but does not provide or directly #include one.
I1_TypedefOnly_Class is defined in "tests/badinc-i1.h", which isn't directly
#included.
I1_TypedefOnly_Class<I1_Class>::i is defined in "tests/badinc-i1.h", which
isn't directly #included.
tests/badinc.cc:1013: expecting 1 diagnostics; actually had 0:
tests/badinc.cc:1256: expecting 4 diagnostics; actually had 3:
I1_Class needs a declaration, but does not provide or directly #include one.
I1_TemplateMethodOnlyClass is defined in "tests/badinc-i1.h", which isn't
directly #included.
I2_Class needs a declaration, but does not provide or directly #include one.
tests/badinc.cc:1915: expecting 4 diagnostics; actually had 3:
I1_Class needs a declaration, but does not provide or directly #include one.
I1_Struct needs a declaration, but does not provide or directly #include one.
I1_TemplateMethodOnlyClass is defined in "tests/badinc-i1.h", which isn't
directly #included.
tests/badinc.h:298: expecting 4 diagnostics; actually had 3:
I2_Class is defined in "tests/badinc-i2.h", which isn't directly #included.
I2_Class needs a declaration, but does not provide or directly #include one.
std::vector is defined in <vector>, which isn't directly #included.
---
Perhaps a recent update to clang broke things somehow. I'll take a look when I
have a free moment.
Original comment by csilv...@gmail.com
on 15 Mar 2011 at 7:25
I just committed a whole slew of updates that were living in our local tree,
and this fixed all the badinc problems on linux (at least on my linux). So you
can try again to isolate the OS X behavior.
Original comment by csilv...@gmail.com
on 18 Mar 2011 at 7:11
I haven't heard anything about this in a while, so I'm presuming it's fixed.
Feel free to reopen if it's not.
Original comment by csilv...@gmail.com
on 25 Oct 2011 at 12:12
Original issue reported on code.google.com by
tonyg@chromium.org
on 15 Mar 2011 at 6:09