search

feliperazeek / playframework-elasticsearch

Integrate Elastic Search in a Play! Framework Application. This module uses JPA events to notify Elastic Search of events of their own. It embeds a running Elastic Search instance for Rapid Development.
http://geeks.aretotally.in/play-framework-module-elastic-search-distributed-searching-with-json-http-rest-or-java
84 stars 43 forks source link

Thread safety #65

Closed isamaru closed 12 years ago

isamaru commented 12 years ago

I am trying to come up with some additions and I am reviewing the current architecture of ElasticSearchPlugin. It seems to me that as it is, the class is not sufficiently thread-safe. I prepared a simple fix in which I replaced all static collections with their Concurrent counterparts. This seems to reduce the risk of some thread shenanigans, but it will also slow us down a bit. What do you think about this?

feliperazeek commented 12 years ago

Could you issue a pull request please?