search

felissaf / pe

0 stars 0 forks source link

Integer overflow #6

Open felissaf opened 2 years ago

felissaf commented 2 years ago

Integer overflow error is not caught in the code hence causing user to not be able to press enter when the user accidentally put in large values. There should be an error message displayed instead "Change in Participation must be between -500 and 500 inclusive.".

Happened when I type: participation 1, 4,10 ses/1 add/20000000000

Actual:

Screenshot 2021-11-12 at 4.56.22 PM.png Screenshot 2021-11-12 at 4.58.08 PM.png

Expected:

Screenshot 2021-11-12 at 5.00.13 PM.png

nus-pe-bot commented 2 years ago

Team's Response

See the below image. Screenshot 2021-11-13 at 6.28.33 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I feel that even if it is deliberate sabotage, the program should still be responsive and not cause any error in the terminal. In this case, when I click enter, there is nothing happening in the UI, which is not the behaviour specified in the UG as when we click enter, the command should either be accepted or there would be an error message shown in the UI, which is not present in this case. This kind of error (integer overflow) should have been anticipated and be caught in the code.