search

feliwir / SharpAudio

Audio playback/capturing engine for C#
MIT License
176 stars 19 forks source link

Openal improvement #28

Closed voldien closed 3 years ago

voldien commented 3 years ago

Add better error message when error occurs. Add additional error check on some forgotten OpenAL calls.

Changed so that a single OpenAL context can only exist, while having each instance of the ALEngine object sharing the OpenAL context. And only release the OpenAL context when no instance of ALEngine remains.

codecov-commenter commented 3 years ago

Codecov Report

Merging #28 (ba92ae8) into master (c64c7ac) will increase coverage by 0.50%. The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #28      +/-   ##
=========================================
+ Coverage    3.68%   4.18%   +0.50%     
=========================================
  Files          33      33              
  Lines         950     979      +29     
=========================================
+ Hits           35      41       +6     
- Misses        915     938      +23
Impacted Files Coverage Δ
src/SharpAudio.ALBinding/Al.cs 0.00% <0.00%> (ø)
src/SharpAudio.ALBinding/Alc.cs 0.00% <0.00%> (ø)
src/SharpAudio/AL/ALSource.cs 0.00% <0.00%> (ø)
src/SharpAudio/AL/ALEngine.cs 16.00% <19.44%> (+10.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c64c7ac...ba92ae8. Read the comment docs.