search

felix-berlin / astro-breadcrumbs

Well configurable breadcrumb component for Astro.js. Create breadcrumbs completely dynamically or specify exactly how they should look.
https://docs.astro-breadcrumbs.kasimir.dev
GNU General Public License v3.0
54 stars 7 forks source link

Slash in base breaks breadcrumbs #262

Closed joppekroon closed 2 months ago

joppekroon commented 2 months ago

Describe the bug I need to set a base in astro.config.mjs that contains a slash, like foo/bar. This unfortunately is not handled correctly, as it generates both a "Home" and homepage-name link on the home page (same for deeper pages). The "Home" link also goes back one level too deep, i.e. it links to /foo.

To Reproduce Set the base property in astro.config.mjs to foo/bar.

Expected behavior The "Home" crumb links to foo/bar and there is not an additional link for the home page.

felix-berlin commented 2 months ago

Thank you for the detailed issue. I also noticed your pull request, thanks for your efforts.

I think I'll find time for it at the weekend.

felix-berlin commented 2 months ago

Should be fixed by your PR ❤️ https://github.com/felix-berlin/astro-breadcrumbs/pull/264

joppekroon commented 2 months ago

Thanks for picking it up!