search

felix91gr / Csdjournal

A Swift wrapper around Linux's `systemd-sdjournal` header
0 stars 1 forks source link

Converting to header only import removing the shim. #2

Closed tonystone closed 4 years ago

tonystone commented 6 years ago

@felix91gr This is the work I did to minimize the code and create a header only module.

felix91gr commented 6 years ago

Also, Tony: do you want ownership of this repo? I'm not going to maintain it anymore, unless I go back to the Swift community which I don't feel is likely to happen. I'd gladly give this one to you :)

tonystone commented 6 years ago

@felix91gr Sure I can take ownership. It will be a little tricky and we'd have to coordinate because TraceLogAdaptiveWriter (which has been published) points to my fork. Do you know it any project point to this repo?

felix91gr commented 6 years ago

TraceLogAdaptiveWriter (which has been published) points to my fork

Hmm. That's tricky indeed. Maybe if we do it quickly...? Or no, wait. We might not even need that.

Your fork's address is https://github.com/tonystone/Csdjournal/, and that should not change whenever you get ownership of the repo, I think.

Do you know if any project points to this repo?

I do not. Lemme investigate, I think no project does, but I'm not sure how to check.

felix91gr commented 6 years ago

Okay I think no other project depends on this, because only I am Watching it and in the Insight tab, under Traffic, it shows only one unique visitor (which would be you)

Edits:

tonystone commented 6 years ago

So in that case, since mine is a complete copy of yours with all your original history, we can break the link between them and simply remove this one. Thoughts?

felix91gr commented 6 years ago

we can break the link between them (...)

Wait, what do you mean by "breaking the link"? Can that be done given that your copy is a fork? I thought forks were unchangeably linked to their base repo :O

(...) and simply remove this one.

This one: https://github.com/felix91gr/Csdjournal, or that one: https://github.com/tonystone/Csdjournal?

Thoughts?

It should depend (on principle) on the answers to my questions, but I think I'm in with whichever scenario you meant.

PS: sorry, I never entered LinkedIn and I left you waiting for our private talk. I guess don't really like them because they've spammed me for like 6 years now :sweat_smile:. Do you use Telegram or something similar? Even Twitter DMs work for me. PPS: I'm using Vagrant today, for a project completely unrelated to the current topic. And... wow, it's so nice. I learned Vagrant thanks to you, and I'm very grateful that I don't have to open a fully-fledged VM in Virtualbox for testing the scripts I'm using vagrant to check for. Thank you, Tony! :blush:

tonystone commented 6 years ago

we can break the link between them (...)

Wait, what do you mean by "breaking the link"? Can that be done given that your copy is a fork? I thought forks were unchangeably linked to their base repo :O

I thought there was a way to do this manually but researching more it seems the safest way to to simply contact github support and ask them to do it. So yes, we can do that.

(...) and simply remove this one.

This one: https://github.com/felix91gr/Csdjournal, or that one: https://github.com/tonystone/Csdjournal?

I was thinking we delete https://github.com/felix91gr/Csdjournal since that does not have any dependencies. We retain all history since mine contains all your history as well.

On the contact, I don't use Telegram (because I have so many other platforms I'm part of it's hard to keep track already). I do have twitter which I haven't used in more than 2 years but send me a DM and we can use it to exchange info to get started with something else. Use tonystone24.