search

felixakiragreen / react-kronos

A fast, intuitive, and elegant date and time picker for React.
https://felixakiragreen.github.io/react-kronos/
MIT License
90 stars 28 forks source link

Update packages, use prop-types instead of React.propTypes #58

Closed michaelryancaputo closed 7 years ago

michaelryancaputo commented 7 years ago

Hey there,

Who likes warnings? Not me!

This PR should get rid of those warnings 👯‍♂️

michaelryancaputo commented 7 years ago

Closing this because no ❤️

felixakiragreen commented 7 years ago

My bad. I've been swamped at work recently. I will try to look at these this weekend and push a new release.

felixakiragreen commented 7 years ago

I merged your code and now I'm getting this error:

screen shot 2017-06-13 at 11 37 59

Still throws the error even when I refactor all PropTypes. I'm currently investigating.

michaelryancaputo commented 7 years ago

I don't have time to check this morning, but are you using the new build of React 15.6.0?

michaelryancaputo commented 7 years ago

I'm wondering if this is related to using static propTypes, possibly a new warning, or error.

felixakiragreen commented 7 years ago

It gave the error for both static propTypes and Component.propTypes = { ... }. Looks like it might be related to HoC's.