felixakiragreen / react-kronos

A fast, intuitive, and elegant date and time picker for React.
https://felixakiragreen.github.io/react-kronos/
MIT License
90 stars 28 forks source link

Remove PropTypes for React 16 Compatibility? #60

Closed Nantris closed 6 years ago

Nantris commented 7 years ago

Is there a plan to do this? Thank you very much for the great package.

felixakiragreen commented 7 years ago

It should already be done in 1.6. Can you show the warning/error you are receiving? And what version are you on?

Nantris commented 7 years ago

@dubert thanks for the reply. I thought I was fully up to date, but I'll double check and report back.

Nantris commented 7 years ago

Just looking at the code in the src directories, I can see that Static PropTypes is still in use.

https://github.com/dubert/react-kronos/blob/master/src/calendar.js:

 static propTypes = {
    datetime: PropTypes.object.isRequired,
    onSelect: PropTypes.func.isRequired,
    level: PropTypes.string.isRequired,
    setLevel: PropTypes.func.isRequired,
    onMouseDown: PropTypes.func,
    onMouseUp: PropTypes.func,
  }
felixakiragreen commented 6 years ago

Updated to 1.7.0 with React 16. Should be fixed.