search

felixarntz / wordpressdev

WordPress core development environment based on Lando.
GNU General Public License v2.0
13 stars 0 forks source link

Disable WSOD protection in WP 5.1 #21

Closed westonruter closed 5 years ago

westonruter commented 5 years ago

Per https://make.wordpress.org/core/2019/01/14/php-site-health-mechanisms-in-5-1/#comment-35228:

I’ve found the WSOD protection an annoyance during development. When I’m coding a plugin and I cause a fatal error to occur, I don’t want to suspend the plugin. Rather I want to fix the bug to make the error go away. At the moment I’m disabling WSOD on my dev environment via:

https://gist.github.com/westonruter/583a42392a0b8684dc268b40d44eb7f1

I don't think WSOD protection should be enabled in this development environment.

felixarntz commented 5 years ago

Agreed. However, I would like to hold off of that since we are working on making this more straightforward. Most likely (and possibly even by the end of today), there will be a constant to more easily allow disabling this entirely.

felixarntz commented 5 years ago

I updated the PR, according to https://core.trac.wordpress.org/changeset/44674

But I can't request a review from @westonruter 😭

westonruter commented 5 years ago

@felixarntz I approve of your changes 🙂