Upgrade to Lando v3.0.0 rc.2

westonruter commented 5 years ago

Lando now supports .lando.yml overrides, so I've added .lando.local.yml to the .gitignore.
The .env handling now finally works so this can eliminate the re-defining of WP_TESTS_DIR.
There can now be more than one .env file. So I've made it so that the config/.env file is loaded at the base, and then there is a .gitignore'd .env in the root in which you can define overrides. For example in mine I have just:
```
# Location of WordPress core directory to run from
WP_CORE_DIR=/app/public/core-dev/src/
```
There were problems with running if conditions in the .lando.yml file so in addition to filing https://github.com/lando/lando/issues/1377 I've just moved things over to bin scripts, which is what I was advised to do in Lando Slack.

westonruter commented 5 years ago

LGTM except for a few remarks. Regarding the new script files, can I assume you just copied commands over there (I didn't wanna compare line by line)? Or did you make adjustments?

I mostly copied, yes. I reformatted them a bit, but I didn't change the commands, other than moving the wp-cli.yml copying into bin/setup-wordpress.sh.

westonruter commented 5 years ago

Confirmed this is also working in 3rc5.

westonruter commented 5 years ago

Follow-up: https://github.com/felixarntz/wordpressdev/pull/24

felixarntz / wordpressdev

Upgrade to Lando v3.0.0 rc.2 #23