felixblaschke / shelf_plus

MIT License
73 stars 14 forks source link

Add test for nested ShelfPlusApp with middlewares #23

Closed davidmartos96 closed 2 years ago

davidmartos96 commented 2 years ago

Hello @felixblaschke ! I noticed a breaking behavior after updating the library. Since commit f184f4771504f7babfb5b3ad5214197fe5cfaf8e the behavior in the regression test I added here does not work correctly.

I'm using that behavior to group routes that share a middleware, and then I mount them in the main app.

Is this breaking behavior working as intended?

felixblaschke commented 2 years ago

Hey @davidmartos96 ... Thanks for raising this. I will look into this 👍

felixblaschke commented 2 years ago

I was able to exchange the implementation, so that the test you made passes.

Thanks for your contribution and wish you joyful weekend :)

davidmartos96 commented 2 years ago

Thank you! You too!