felixc / rexiv2

Rust library for read/write access to media-file metadata (Exif, XMP, and IPTC)
GNU General Public License v3.0
79 stars 17 forks source link

Provide access to raw tag value. #32

Closed Naarakah closed 5 years ago

Naarakah commented 5 years ago

An implementation for https://github.com/felixc/rexiv2/issues/15. I'm still new to rust so let me know if there is any issue with my code.

felixc commented 5 years ago

Hey, need any help to get this landed? Do the steps in https://github.com/felixc/rexiv2/pull/32#pullrequestreview-261602272 make sense? Thanks again!

Naarakah commented 5 years ago

Hey, sorry for the delay I think I made all the required changes.

felixc commented 5 years ago

Thank you again for this improvement! I've merged it in with https://github.com/felixc/rexiv2/commit/5a90ebca7a0becbdafad923069a57febf59968ae. GitHub didn't recognize it because I had to tweak the commit in order to include a fix from https://github.com/felixc/gexiv2-sys/commit/11e04f4cf073de591e99c65cee1896b99a928962 because I'd broken the gexiv2-sys dependency in the meantime. Marking it as "closed" but it was in fact merged.