felixc / rexiv2

Rust library for read/write access to media-file metadata (Exif, XMP, and IPTC)
GNU General Public License v3.0
79 stars 17 forks source link

New API: Metadata::new_from_app1_segment #62

Closed hfiguiere closed 1 year ago

hfiguiere commented 1 year ago

Draft as it requires https://github.com/felixc/gexiv2-sys/pull/21

Tested it locally.

Use case with https://github.com/maxicarlos08/gphoto2-rs/pull/53

hfiguiere commented 1 year ago

Requirements have been released.

felixc commented 1 year ago

I updated Cargo.toml to use the latest version of glib-sys to match gexiv2-sys, which fixed a build failure that only appeared if you build with the raw-tag-access feature.

I've also reconfigured CircleCI to run builds for pull requests and not just the main branch.

felixc commented 1 year ago

Right; will need to bump MSRV here too.

codecov[bot] commented 1 year ago

Codecov Report

Base: 68.96% // Head: 69.13% // Increases project coverage by +0.16% :tada:

Coverage data is based on head (e765ebe) compared to base (41774f4). Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #62 +/- ## ========================================== + Coverage 68.96% 69.13% +0.16% ========================================== Files 1 1 Lines 928 946 +18 ========================================== + Hits 640 654 +14 - Misses 288 292 +4 ``` | [Impacted Files](https://codecov.io/gh/felixc/rexiv2/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Felix+Crux) | Coverage Δ | | |---|---|---| | [src/lib.rs](https://codecov.io/gh/felixc/rexiv2/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Felix+Crux#diff-c3JjL2xpYi5ycw==) | `69.13% <77.77%> (+0.16%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Felix+Crux). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Felix+Crux)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hfiguiere commented 1 year ago

Here is a sample:

exif_IMG_6036.JPG.bin.gz

hfiguiere commented 1 year ago

I added a test for it now.

felixc commented 1 year ago

Thank you very much!

I hope it's OK with you that I added you to the contributors list in CONTRIBUTORS.md

I appreciate the test, too. It's something I didn't add enough to the codebase early on, so now I'm trying to bring up the coverage on new code at least to make it safer to make changes in the future. I did end up changing it to use a smaller buffer to minimize the size of the repo diffs/downloads, though.

Thanks again for the contribution -- I'll push out a new version including this soon!