Closed hfiguiere closed 1 year ago
Requirements have been released.
I updated Cargo.toml
to use the latest version of glib-sys
to match gexiv2-sys
, which fixed a build failure that only appeared if you build with the raw-tag-access
feature.
I've also reconfigured CircleCI to run builds for pull requests and not just the main
branch.
Right; will need to bump MSRV here too.
Base: 68.96% // Head: 69.13% // Increases project coverage by +0.16%
:tada:
Coverage data is based on head (
e765ebe
) compared to base (41774f4
). Patch coverage: 77.77% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Here is a sample:
I added a test for it now.
Thank you very much!
I hope it's OK with you that I added you to the contributors list in CONTRIBUTORS.md
I appreciate the test, too. It's something I didn't add enough to the codebase early on, so now I'm trying to bring up the coverage on new code at least to make it safer to make changes in the future. I did end up changing it to use a smaller buffer to minimize the size of the repo diffs/downloads, though.
Thanks again for the contribution -- I'll push out a new version including this soon!
Draft as it requires https://github.com/felixc/gexiv2-sys/pull/21
Tested it locally.
Use case with https://github.com/maxicarlos08/gphoto2-rs/pull/53