codecov[bot]
commented
1 year ago Codecov Report
Base: 68.31% // Head: 71.15% // Increases project coverage by +2.83% :tada:
Coverage data is based on head (
e8ceff8) compared to base (18008e5). Patch coverage: 97.05% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #69 +/- ## ========================================== + Coverage 68.31% 71.15% +2.83% ========================================== Files 1 1 Lines 950 981 +31 ========================================== + Hits 649 698 +49 + Misses 301 283 -18 ``` | [Impacted Files](https://codecov.io/gh/felixc/rexiv2/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Felix+Crux) | Coverage Δ | | |---|---|---| | [src/lib.rs](https://codecov.io/gh/felixc/rexiv2/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Felix+Crux#diff-c3JjL2xpYi5ycw==) | `71.15% <97.05%> (+2.83%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Felix+Crux). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Felix+Crux):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This matches the real-world behaviour of apps that only set lat/long when drawing points on a map.
What made this tricky is that up until gexiv2 0.12.2, this was not necessary. If altitude (or indeed latitude or longitude) were missing, the function would still return successfully overall as long as at least one piece of data could be found. However in 0.12.2 this changes so that all three components need to be present for
gexiv2_metadat_get_gps_infoto returnTRUE.I am not sure if this change was intentional, so I have filed a bug upstream with gexiv2, but in the meantime we still need a workaround. Bug report: https://gitlab.gnome.org/GNOME/gexiv2/-/issues/72
Debian Stable as of today ships with 0.12.1, so I couldn't reproduce or test this locally, but the CircleCI Mac OSX executor is installing a recent version of the library via homebrew, so if the tests pass there it should be good.
This patch works around the problem by making the altitude (and only altitude) component of
GpsInfoOptional. This is slightly annoyingly asymmetrical, but makes sense in reality as there's no reason to have, say, a latitude and an altitude but not a longitude. The workaround relies on the implementation detail that gexiv2 upstream happens to check and set latitude and longitude first, and altitude last. That means that even if we get aFALSEreturn, the latitude and longitude pointers may nonetheless have been populated, if the problem was simply that altitude was unset.For compatibility with various versions of gexiv2, we handle both cases: the newer behaviour that returns
FALSE, and also the older behaviour that returnsTRUEbut has altitude set to0.0.Addresses bug report #42
References: