add parameters to with_launch_file decorator #29

[schmidta83]

Implements #29.

[Timple]

Wouldn't the term launch_arguments be more correct? You cannot add parameters to a launchfile. As it wouldn't know to which node to add the parameters.

[felixdivo]

Wouldn't the term launch_arguments be more correct? You cannot add parameters to a launchfile. As it wouldn't know to which node to add the parameters.

I think you are right. Thanks for checking this!

@schmidta83 We can keep all as-is; just need to rename the parameter and docstring above to call it "launch arguments passed to the launch file" instead of "parameters passed to the node". :)

[schmidta83]

Sorry, was busy last weeks... @Timple , good point! Will change it.

@felixdivo Thanks for the information.

[felixdivo]

No worries, @schmidta83. I was unresponsive for weeks, too. 🙃

[schmidta83]

@felixdivo All suggegtions are adapted. You can review again.