Fixes #81 and better Qt5 integration

felixendres / rgbdslam_v2

RGB-D SLAM for ROS

GNU General Public License v3.0

935 stars 399 forks source link

Closed agilmor closed 6 years ago

agilmor commented 6 years ago

Some CMake improvements, mainly to fix #81 and other build errors on Debian.

agilmor commented 6 years ago

My system is quite old: debian-jessie. We are moving to Ubuntu 18.04 (not yet tested).

felixendres commented 6 years ago

Would your merge request work without the c++11 option?

agilmor commented 6 years ago

No. I've uncommented the line to make it work. I don't remeber the exact error.. but it was related to Qt5 (it needs C++11).

felixendres commented 6 years ago

Which ROS do you use?

agilmor commented 6 years ago

Kinetic. From sources. It's a small HTC setup.

felixendres commented 6 years ago

Since you and #92 confirm that it works on kinetic, I merged it. Thanks for the contribution (also to @DaikiMaekawa)