search

felixfbecker / PSKubectl

kubectl with the power of the object pipeline
MIT License
61 stars 9 forks source link

Make module compatible for any version of PSCore by targeting netstandard2.0 #30

Closed bergmeister closed 5 years ago

bergmeister commented 5 years ago

Is there a reason for not using .Net Standard or are there any other blockers in terms of dependencies? I see there are 8 .Net Apis that are not part of the standard but I am sure we could use alternative ones for the same behaviour.

felixfbecker commented 5 years ago

I think there was some dependency that only worked with PSCore but I don't remember any more. I'm not super familiar with the whole .NET stuff so I'd be happy to review a PR

felixfbecker commented 5 years ago

I think it was Microsoft.AspNetCore.JsonPatch. However my current plan is to only support server-side apply, so that wouldn't be needed anymore

felixfbecker commented 5 years ago

Looks like we are targeting this now