felixfbecker / PSKubectl

kubectl with the power of the object pipeline

MIT License

61 stars 9 forks source link

Update .Net Core SDK from 2.1.400 to 2.2.401 #34

Closed bergmeister closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #34 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #34   +/-   ##
======================================
  Coverage    47.8%   47.8%           
======================================
  Files          26      26           
  Lines         797     797           
======================================
  Hits          381     381           
  Misses        416     416

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e454e0f...2a236b3. Read the comment docs.

felixfbecker commented 5 years ago

Does this have any advantages or disadvantages? E.g. could it break compatibility with older PowerShell Core versions?

bergmeister commented 5 years ago

This just so that the built .Net binaries were built using the latest patched version of msbuild as there are usually security related fixed in SDK updates, in the meantime the latest LTS version is already 2.1.801 (too new for Travis at the moment, so I went back to 2.1.700) https://dotnet.microsoft.com/download/dotnet-core/2.1 Since we use .Net Standard now, we could even use the 2.2 SDK now, which might have faster build times, 2.1 is fine as well though and has LTS (long term support). This does not affect PS at all, what matters is the runtime target in the csproj (which is now netstandard2.0, on which any version of PSCore can run, even 7.0)

felixfbecker commented 5 years ago

I'd be down for 2.2, wanna do that?

bergmeister commented 5 years ago

yes, we can definitely try that. Let's see if travis supports it. Technically we could already go for 3.0-preview because, which is already supported for production but will be released anyway in a month at .net conf

bergmeister commented 5 years ago

Ok, it seems this travis environment does not support 2.2 well. I suggest to update trusty to xenial (i.e. Ubuntu 14 to 16). Mainstream support for Ubuntu 14 has already ended and PowerShell is not supporting it any more. I'd say that is another PR though...

felixfbecker commented 5 years ago

I already switched to xenial in #38

felixfbecker commented 5 years ago

Pushed to master

bergmeister commented 5 years ago

Ok, thanks, it worked now :-)

felixfbecker commented 5 years ago

:tada: This PR is included in version 0.11.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: