search

felixfbecker / PSKubectl

kubectl with the power of the object pipeline
MIT License
61 stars 9 forks source link

Use dotnet build to reduce the number of necessary DLLS #40

Closed bergmeister closed 5 years ago

bergmeister commented 5 years ago

Had to use workaround of NuGet bug where dotnet build does not copy the NuGet DLLs into the bin folder by default. This reduces the size of the module from 9.7 MB to to 6.02MB, which is a further reduction of 38%. This is possible and relatively safe because PowerShell ships nearly the complete .Net Core Runtime already and the passing tests show this. What we need are the DLLs from the 3 NuGet packages that you reference. I also delete the Newtonsoft.Json DLL as PS ships with that as well aready and currently cannot load more than 1 instance of 1DLL anyway. You want to rather rely on the version loaded that is shipped by the specific version of PowerShell rather than having different behaviour depending on which version of Newtonsoft gets loaded first (which would depend on the cmdlet execution order)

codecov[bot] commented 5 years ago

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #40   +/-   ##
======================================
  Coverage    47.8%   47.8%           
======================================
  Files          26      26           
  Lines         797     797           
======================================
  Hits          381     381           
  Misses        416     416

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cead96...a86db2a. Read the comment docs.

felixfbecker commented 5 years ago

:tada: This PR is included in version 0.11.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: