felixfbecker / PowerGit

Git with the power of the PowerShell object pipeline. For macOS, Linux and Windows.

Apache License 2.0

30 stars 6 forks source link

build: update to .NET Core 3 #20

Closed bording closed 4 years ago

bording commented 4 years ago

This uses the GeneratePathProperty feature to get a path reference to the runtimes folder on disk and then ensures it gets copied by adding it to the project as Content.

It order to set GeneratePathProperty that does mean you'll need an explicit reference to LibGit2Sharp.NativeBinaries instead of relying on the transtive reference being pulled in. That means you'll have to manually update that to be the correct version whenever you update LibGit2Sharp.

codecov[bot] commented 4 years ago

Codecov Report

Merging #20 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   59.44%   59.44%           
=======================================
  Files          44       44           
  Lines         794      794           
  Branches        2        2           
=======================================
  Hits          472      472           
  Misses        320      320           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5408ea4...9a268b3. Read the comment docs.

felixfbecker commented 4 years ago

This seems to work fine on Linux and Window, but for some reason makes the build hang on macOS. I got a prompt that it is trying to access files from a network volume, and my desktop, and fans start going crazy. dotnet CLI uses 200% CPU. Can't even abort it without force-quitting. Any idea?

felixfbecker commented 4 years ago

:tada: This PR is included in version 0.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: