search

felixfbecker / node-sql-template-strings

ES6 tagged template strings for prepared SQL statements 📋
ISC License
610 stars 40 forks source link

version 2.x is not compatible with github.com/felixge/node-mysql #6

Closed taojoe closed 8 years ago

taojoe commented 8 years ago

version 2.x use class 'get sql' to construct the sql string, this is not working with node-mysql.

node-mysql use for(prop in sql), so the 'get sql' will not be called.

please see https://github.com/mysqljs/mysql/blob/master/lib/Connection.js#L50

felixfbecker commented 8 years ago

Should be fixed in 0d660071d006591bcaac90938c518bd705c12161, could you please verify?

taojoe commented 8 years ago

Yes, it works. Thanks.

felixfbecker commented 8 years ago

I will make a release on monday when Im home

taojoe commented 8 years ago

Could you make the release today?

felixfbecker commented 8 years ago

Sorry, I had no internet access the whole weekend. Released

taojoe commented 8 years ago

Thanks.