search

felixfbecker / php-language-server

PHP Implementation of the VS Code Language Server Protocol 🆚↔🖥
ISC License
1.15k stars 185 forks source link

Go to Definition in PHPDoc comments #134

Open felixfbecker opened 7 years ago

felixfbecker commented 7 years ago

From @razvanphp on November 4, 2016 18:54

Not sure how I can explain better, but this would be very useful, especially for private variables in classes.

Thank you for this great extension, makes VSCode perfect!

Copied from original issue: felixfbecker/vscode-php-intellisense#28

felixfbecker commented 7 years ago

I would love to support this, but I don't get any location info from phpDocumentor for the tags.

felixfbecker commented 7 years ago

From @razvanphp on November 4, 2016 19:3

Maybe you can open a feature request issue there?

felixfbecker commented 7 years ago

https://github.com/phpDocumentor/ReflectionDocBlock/issues/87

joelday commented 7 years ago

PHP support for https://github.com/joelday/vscode-docthis has been a pretty big request. I'm working on switching to a multiple language architecture, but I want to make sure that I'm going in the right direction or if I should do this at all. I sent @mousetraps a quick e-mail about this, too.

This is also pretty sensitive given the runtime implications of PHPDoc comments, which is going to require very careful testing and CI on my part. Any thoughts?

felixfbecker commented 7 years ago

@joelday I think this functionality can be provided much easier in the language server. But automatic documentation !== go to definition in docblocks.

joelday commented 7 years ago

@felixfbecker

But automatic documentation !== go to definition in docblocks.

Totally. :)

razvanphp commented 6 years ago

is this now possible due to adoption of Microsoft/tolerant-php-parser?

vbabak commented 4 years ago

@felixfbecker is PHPDoc implemented? -- edit -- I mean autocomplete based on PHPDoc (@method, @see, @var) and corresponding code navigation.